Add Positron instantiation service test helpers; refactor tests to use runtime services #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstrayer
approved these changes
Nov 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for writing unit tests for the runtime session service since I intend on making changes to it for #2671.
The main addition is the
positronWorkbenchInstantiationServicefunction, which sets up a test instantiation service with a bunch of test dummies, following upstream'sworkbenchInstantiationServicefunction. I also refactored our existing unit tests to use the new function.QA Notes
Positron unit tests should pass. They can be run locally with:
There are a few minor code changes to runtime-related code, mainly to fix leaked disposables, which could use a review.